Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIH-10346 - Manage team page is not cleared #1454

Merged
merged 10 commits into from
Dec 5, 2024

Conversation

marcogagliardi
Copy link
Contributor

Jira link

VIH-10346

Change description

Added clearUsers function

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

@marcogagliardi marcogagliardi requested review from a team as code owners December 3, 2024 11:46
Copy link
Contributor

@will-craig will-craig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a unit test?

@marcogagliardi marcogagliardi merged commit 239f98c into master Dec 5, 2024
10 of 11 checks passed
shaed-parkar pushed a commit that referenced this pull request Dec 6, 2024
* added clearUsers function

* test fix

* added test

* Update justice-users.service.spec.ts

* Update justice-users.service.spec.ts

* Update justice-users.service.spec.ts

* Update justice-users.service.spec.ts

* Update justice-users.service.spec.ts

* updated test

---------

Co-authored-by: William Craig <[email protected]>
@shaed-parkar shaed-parkar deleted the VIH-10346-Manage-team-page-is-not-cleared branch December 6, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants