Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VIH-10899 upgrade bookings api client #1449

Merged
merged 18 commits into from
Dec 5, 2024
Merged

VIH-10899 upgrade bookings api client #1449

merged 18 commits into from
Dec 5, 2024

Conversation

shaed-parkar
Copy link
Contributor

Jira link

VIH-10899

Change description

This pull request includes updates to dependencies and refactors several unit tests to use the new version of API requests and responses. Removal of references to obsolete V1 structures such as CaseRoles and HearingTypes

@shaed-parkar shaed-parkar requested review from a team as code owners November 25, 2024 21:00
@shaed-parkar shaed-parkar force-pushed the feature/VIH-10899_upgrade_bookings_api_client branch from 0878469 to 818cb51 Compare November 28, 2024 10:18
oliver-scott
oliver-scott reviewed Nov 28, 2024
View reviewed changes
Copy link
Contributor

@oliver-scott oliver-scott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any chance we could fix the sonar issues? Looks good otherwise

@shaed-parkar shaed-parkar force-pushed the feature/VIH-10899_upgrade_bookings_api_client branch 2 times, most recently from 963a00c to 42e2050 Compare December 3, 2024 20:45
oliver-scott
oliver-scott approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@oliver-scott oliver-scott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job!

@shaed-parkar shaed-parkar force-pushed the feature/VIH-10899_upgrade_bookings_api_client branch from 66e1a4e to 33540c5 Compare December 5, 2024 17:39
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@shaed-parkar shaed-parkar merged commit 02d0cf9 into master Dec 5, 2024
10 of 11 checks passed
@shaed-parkar shaed-parkar deleted the feature/VIH-10899_upgrade_bookings_api_client branch December 5, 2024 18:05
shaed-parkar added a commit that referenced this pull request Dec 6, 2024
@shaed-parkar
VIH-10899 upgrade bookings api client (#1449)
b891a4e 
* VIH-10899 remove obsolete hearing types and case roles
* get venue name and case type name on get using the codes and service ids
* move hearingTypes to reference data service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komaldabhi1509 komaldabhi1509 komaldabhi1509 approved these changes

@oliver-scott oliver-scott oliver-scott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaed-parkar @oliver-scott @komaldabhi1509