Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIH-11093 Sonar fixes #1442

Merged
merged 9 commits into from
Nov 4, 2024
Merged

VIH-11093 Sonar fixes #1442

merged 9 commits into from
Nov 4, 2024

Conversation

oliver-scott
Copy link
Contributor

@oliver-scott oliver-scott commented Oct 30, 2024

Jira link

https://tools.hmcts.net/jira/browse/VIH-11075

Change description

  • Additional fixes for sonar issues
  • hearing-schedule.component.ts - refactor initForm() into smaller functions
  • Refactoring to remove boolean arguments from functions
  • Remove obsolete file - profile.arm.json
  • Update pupeteer package - fixes chromium plugin issues when running local tests

Automation test results

image

@oliver-scott oliver-scott marked this pull request as ready for review October 31, 2024 17:00
@oliver-scott oliver-scott requested review from a team as code owners October 31, 2024 17:00
Copy link

sonarqubecloud bot commented Nov 1, 2024

@oliver-scott oliver-scott merged commit cce4274 into master Nov 4, 2024
10 checks passed
@oliver-scott oliver-scott deleted the VIH-11093-sonar-fixes-2 branch November 4, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants