Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VIH-10363 Fix judge name disappearing on booking list when V2 switched on #1316

Merged
merged 2 commits into from
Dec 11, 2023
Merged

VIH-10363 Fix judge name disappearing on booking list when V2 switched on #1316

merged 2 commits into from
Dec 11, 2023

Conversation

oliver-scott
Copy link
Contributor

@oliver-scott oliver-scott commented Dec 11, 2023 •
edited
Loading

Jira link (if applicable)

https://tools.hmcts.net/jira/browse/VIH-10363

Change description

2 changes needed:

  1. Get the judge name from judiciary participants if the judge is booked as a judiciary participant
  2. Update is_judge and is_staff_member to look at the user role name. The case and hearing role are null when V2 is switched on so instead read from user role name, which is populated for both V1 and V2

@oliver-scott oliver-scott changed the title VIH-10363 Fix judge name disappearing on booking list VIH-10363 Fix judge name disappearing on booking list when V2 switched on Dec 11, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@oliver-scott oliver-scott marked this pull request as ready for review December 11, 2023 13:24
@oliver-scott oliver-scott requested review from a team as code owners December 11, 2023 13:24
marcogagliardi
marcogagliardi approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@marcogagliardi marcogagliardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏽

@oliver-scott oliver-scott merged commit d93b208 into master Dec 11, 2023
10 checks passed
@oliver-scott oliver-scott deleted the bug/VIH-10363-judge-name branch December 11, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komaldabhi1509 komaldabhi1509 komaldabhi1509 approved these changes

@marcogagliardi marcogagliardi marcogagliardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliver-scott @marcogagliardi @komaldabhi1509