VIH-10326 Fix v2 toggle issues #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will-craig
approved these changes
Nov 17, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
komaldabhi1509
approved these changes
Nov 20, 2023
|
Kudos, SonarCloud Quality Gate passed! |
will-craig
pushed a commit
that referenced
this pull request
Nov 29, 2023
* Fix v2 toggle issues * Reinstate api tests * Update search service * Added null coalesc for non populated johs * Check fo null judicary participant before mapping --------- Co-authored-by: William Craig <[email protected]> (cherry picked from commit 89f8d85)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link (if applicable)
https://tools.hmcts.net/jira/browse/VIH-10326
Change description
Fixes the admin web issues when the Use Bookings API V2 feature flag is toggled off.
The issue was introduced as part of adding the Judicial Office Holders component.
The PostJudgesBySearchTerm endpoint had been removed and the search.service was changed to call a different endpoint which returns a PersonResponse instead of a JudgeResponse. This change was not needed as the search service is not referenced by the Judicial Office Holders component, so I have reverted the service changes and reinstated the original API endpoint and its tests.