Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VIH-10084 Change Case Role & Hearing Role dropdowns to a single list #1274

Merged
merged 20 commits into from
Oct 9, 2023
Merged

VIH-10084 Change Case Role & Hearing Role dropdowns to a single list #1274

merged 20 commits into from
Oct 9, 2023

Conversation

oliver-scott
Copy link
Contributor

@oliver-scott oliver-scott commented Sep 28, 2023 •
edited
Loading

Jira link (if applicable)

https://tools.hmcts.net/jira/browse/VIH-10084

Change description

  • Displays a single role list of flat hearing roles when reference data is toggled on
  • Changes to be able to book via the V2 endpoints using a hearing role code instead of hearing role name

@oliver-scott oliver-scott marked this pull request as ready for review September 29, 2023 11:00
@oliver-scott oliver-scott requested review from a team as code owners September 29, 2023 11:00
himesh99
himesh99 approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@himesh99 himesh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 16 Code Smells

98.1% 98.1% Coverage
0.0% 0.0% Duplication

@oliver-scott oliver-scott merged commit 3e7a49e into master Oct 9, 2023
@oliver-scott oliver-scott deleted the feature/VIH-10084-single-role-list branch October 9, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@will-craig will-craig will-craig approved these changes

@himesh99 himesh99 himesh99 approved these changes

@komaldabhi1509 komaldabhi1509 komaldabhi1509 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oliver-scott @will-craig @himesh99 @komaldabhi1509 @benjamin-v1