Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIH-10160 Added new booking status to display in booking list and detail views #1270

Merged
merged 19 commits into from
Sep 27, 2023

Conversation

will-craig
Copy link
Contributor

@will-craig will-craig commented Sep 15, 2023

JIRA link (if applicable)

hmcts/vh-bookings-api#721

Change description

Utilised the Ejud no judge badge, for the new booking statuses

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

@will-craig will-craig changed the title VVIH-10160 Added new booking status' display to booking list and detial views VIH-10160 Added new booking status' display to booking list and detial views Sep 17, 2023
@will-craig will-craig changed the title VIH-10160 Added new booking status' display to booking list and detial views VIH-10160 Added new booking status display to booking list and detial views Sep 17, 2023
@will-craig will-craig changed the title VIH-10160 Added new booking status display to booking list and detial views VIH-10160 Added new booking status to display in booking list and detail views Sep 17, 2023
@will-craig will-craig marked this pull request as ready for review September 18, 2023 10:38
@will-craig will-craig requested review from a team as code owners September 18, 2023 10:38
Copy link
Contributor

@shaed-parkar shaed-parkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but the comment might be worth looking at if it makes sense and you have the time

Copy link
Contributor

@shaed-parkar shaed-parkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of points worth considering

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

96.3% 96.3% Coverage
0.0% 0.0% Duplication

@will-craig will-craig merged commit 29722da into master Sep 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants