-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VIH-10160 Added new booking status to display in booking list and detail views #1270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but the comment might be worth looking at if it makes sense and you have the time
...site/AdminWebsite/ClientApp/src/app/bookings-list/bookings-list/bookings-list.component.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, couple of points worth considering
...site/AdminWebsite/ClientApp/src/app/bookings-list/booking-status/booking-status.component.ts
Show resolved
Hide resolved
AdminWebsite/AdminWebsite/ClientApp/src/app/common/model/bookings-list.model.ts
Outdated
Show resolved
Hide resolved
# Conflicts: # AdminWebsite/AdminWebsite.AcceptanceTests/packages.lock.json # AdminWebsite/AdminWebsite.IntegrationTests/packages.lock.json # AdminWebsite/AdminWebsite.UnitTests/packages.lock.json # AdminWebsite/AdminWebsite/AdminWebsite.csproj
Kudos, SonarCloud Quality Gate passed! |
JIRA link (if applicable)
hmcts/vh-bookings-api#721
Change description
Utilised the Ejud no judge badge, for the new booking statuses
Does this PR introduce a breaking change? (check one with "x")