Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VIH-10158 Error adding panel member to booking #1268

Merged
merged 2 commits into from
Sep 13, 2023
Merged

VIH-10158 Error adding panel member to booking #1268

merged 2 commits into from
Sep 13, 2023

Conversation

oliver-scott
Copy link
Contributor

@oliver-scott oliver-scott commented Sep 13, 2023 •
edited
Loading

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/VIH-10158

Change description

Fixes an issue adding a panel member when ejud is toggled on.

  • Check for nulls before trimming whitespace

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.0% 92.0% Coverage
0.0% 0.0% Duplication

@oliver-scott oliver-scott marked this pull request as ready for review September 13, 2023 14:27
@oliver-scott oliver-scott requested review from a team as code owners September 13, 2023 14:27
shaed-parkar
shaed-parkar reviewed Sep 13, 2023
View reviewed changes
Copy link
Contributor

@shaed-parkar shaed-parkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure if we should allow empty fields here. Rather filter search results or allow the field to be editable

...dminWebsite/ClientApp/src/app/booking/add-participant-base/add-participant-base.component.ts Show resolved Hide resolved
@oliver-scott oliver-scott merged commit 0b1a97e into master Sep 13, 2023
9 checks passed
@oliver-scott oliver-scott deleted the bug/VIH-10158-error-adding-panel-member-to-booking branch September 13, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komaldabhi1509 komaldabhi1509 komaldabhi1509 approved these changes

@shaed-parkar shaed-parkar shaed-parkar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliver-scott @shaed-parkar @komaldabhi1509