Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIH-10152 Audio recording required being changed to true on edit for Crime Crown Court and CACD #1263

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

oliver-scott
Copy link
Contributor

@oliver-scott oliver-scott commented Sep 6, 2023

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/VIH-10152

Change description

Fixes an issue where the Audio Recording Required flag is changed from false to true when editing a booking with an interpreter for the Crime Crown Court or CACD case types. It should always be set to false for these case types.

The logic for whether this flag should be true or false lives in the frontend. However the backend duplicates this and overrides the value in the request if there are interpreters. This is not needed.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

@oliver-scott oliver-scott requested review from a team as code owners September 6, 2023 11:15
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@marcogagliardi marcogagliardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏽

@oliver-scott oliver-scott merged commit ec31d9f into master Sep 6, 2023
@oliver-scott oliver-scott deleted the bug/VIH-10152-audio-recording-time branch September 6, 2023 13:10
oliver-scott added a commit that referenced this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants