Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Tool bar above zoom bar and shift clicking zoom in #1

Closed
wants to merge 145 commits into from
Closed

feat: Tool bar above zoom bar and shift clicking zoom in #1

wants to merge 145 commits into from

Conversation

JennChao
Copy link
Collaborator

Updates

Demo screenshot or recording

圖片

Review checklist (for reviewers only)

  • Demos all features
  • Documented/annotated
  • Matches UI/UX specs
  • Meets the code style guide
  • Accessible
  • Mobile first (responsive)
  • RTL support (bidirectional text)
  • Performant (limited bloat)

hlyang397 and others added 30 commits July 16, 2020 10:30
@hlyang397
feat: initial zoom bar implementation from PR 511
fd481a4
@hlyang397
fix: update ZoomBar to match new data format
e462194 
- fix trailing-comma
- update scales-cartesian.getValueFromScale()
- update line time-series 15 seconds demo data
@hlyang397
feat: use d3-brush to implement selection
0a15537
@hlyang397
fix: add left margin to align to chart
ef9a458 
- using .scss to set fill and stroke color
@hlyang397
feat: set brush selection to zoomDomain in Model
13b3e27 
- use flag to avoid recursive update event
@hlyang397
feat: create ZoomBarOptions and default configuration
973ff9d 
- default to disable zoombar
@hlyang397
feat: create zoombar story in storybook
23d8a7b
@hlyang397
fix: set tslint trailing-comma to never
a6d9bc6
@hlyang397
fix: allow zoomDomain to update for every brush event
bd8d77e
@hlyang397
feat: provide ZoomBar options for brush event callback
0397261 
- selected x range and domain as callback parameters
@JennChao @hlyang397
feat: apply clipPath to line chart - v1
1ac8810
@JenniferChao-tc @hlyang397
feat: apply cover to axis chart
8183536
@JennChao @hlyang397
refactor: clean code
0fc01ea
@hlyang397
feat: set axes margins as zoom bar left margin
31b796a
@JennChao @hlyang397
refactor: add todo
fde62aa
@hlyang397
fix: double the minTickSize for datetime ticks
8977bcf
@JennChao @hlyang397
feat: add chart brush
6881703
@JennChao @hlyang397
refactor: add brush in axis chart component
6f83f7b
@hlyang397
refactor: move brush functions to ZoomBar class function
5d7056d
@JennChao @hlyang397
fix: handel situation of zoom bar selection[0] equals selection[1]
1f5a6b8
@hlyang397
feat: ZoomBar could update brush based on zoomDomain
fcb4c44 
- fix some brush handle UI bugs
@hlyang397
fix: handle empty selection
5ae26bb
@JennChao @hlyang397
fix: set to default full range when same selection of brush
0dab26a
@hlyang397
fix: fix bug when selection === null
eb5f969
@hlyang397
feat: add ZoomBarOptions.initZoomDomain
7aaabea 
- update storybook
- add init() and destroy() in ZoomBar
@hlyang397
feat: create Zoombar storybook demo group
68e095c
@JennChao @hlyang397
fix: apply cover to stacked bar
e4c976a
@hlyang397
feat: create ZoomBar event and handler
cbec680 
- use Events.ZoomBar.UPDATE to handle axesMargins update
@hlyang397
fix: fix merge error
87e3067 
- move ZoomBarOptions from BaseChartOptions to AxisChartOptions
@hlyang397
feat: update color for non-highlighted areas
a28b399 
- remove zoombar graph line
- add zoombar unselected graph area with clip
- add zoombar baseline
- clear d3.brush selection style
hlyang397 added 19 commits July 21, 2020 10:16
@hlyang397
refactor: use Tools.getProperty to get initialZoomDomain
ee2efbd
@hlyang397
refactor: Change Cover to ChartClip
37c9afe
@hlyang397
refactor: Change Brush to ChartBrush
21c4866
@hlyang397
refactor: set model.set() function default config
f0b2786
@hlyang397
fix: remove unnecessary selector
d5955a3
@hlyang397
refactor: create reusable getMainXScaleType()
03d3ba0
@hlyang397
refactor: make sure zoom bar only shows with supported options
56c3e73 
- zoomBar is available when
  -- zoomBar is enabled
  -- main X axis position is bottom
  -- main X axis scale type is time
@hlyang397
refactor: set clip-path url in containerSVG
8983eff
@hlyang397
refactor: dispatch zoombar selection events instead of callback
7246a75
@hlyang397
feat: update chart brush selection storke to dash
cbb0ec7
@hlyang397
feat: show tooltip when mouseover zoombar handle
e91c62f
@hlyang397
fix: avoid tick rotation flip during zoom domain changing
04695f7 
- always rotate ticks during zoom domain changing
@hlyang397
fix: move chart brush selection above all graphs
4e783e4
@hlyang397
fix: use another svg to display front selection
d554812
@hlyang397
fix: set cursor for front selection
dbc0e4b
@hlyang397
fix: use unique chartClipId for each chart
1e68f23
@hlyang397
fix: keep zoom bar handle inside zoom bar range
ad31729
@hlyang397
fix: use DOMUtils.appendOrSelect in case the element does not exist yet
abfd3e1
@hlyang397
feat: allow user to set zoom bar data
e1d4636
@JennChao JennChao closed this Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theiliad theiliad Awaiting requested review from theiliad theiliad is a code owner

@hlyang397 hlyang397 Awaiting requested review from hlyang397

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JennChao @theiliad @hlyang397 @JenniferChao-tc