Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Linux builds and upgrade CEF #148

Merged
merged 6 commits into from
Oct 24, 2024
Merged

Fix Linux builds and upgrade CEF #148

merged 6 commits into from
Oct 24, 2024

Conversation

cadivus
Copy link
Collaborator

@cadivus cadivus commented Sep 21, 2024

Hi!

On Ubuntu 24.04, builds fail (see build_errors.txt).

This is my toolchain:

$ gcc --version
gcc (Ubuntu 12.3.0-17ubuntu1) 12.3.0
Copyright (C) 2022 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

$ g++ --version
g++ (Ubuntu 12.3.0-17ubuntu1) 12.3.0
Copyright (C) 2022 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

$ clang --version
Ubuntu clang version 18.1.3 (1ubuntu1)
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

$ cmake --version
cmake version 3.28.3

CMake suite maintained and supported by Kitware (kitware.com/cmake).

This PR fixes that and upgrades CEF by using offical builds (https://github.com/chromiumembedded/cef?tab=readme-ov-file#quick-links).

@SinyimZhi
Copy link
Collaborator

I will check it in the next few day.

@cadivus
Copy link
Collaborator Author

cadivus commented Oct 22, 2024

@SinyimZhi
I fixed the arm64 builds too, I tested it on Ubuntu 24.04 aarch64 (VMware on Macbook M1) and x86_64.

This is the Flutter build I used in the arm64 VM since there are no official Linux builds for arm64:
https://github.com/zhzhzhy/Flutter-SDK-ARM64

Copy link
Collaborator

@SinyimZhi SinyimZhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making some amazing contributions. Due to some recent work and family matters, I don't have much energy to focus on this project, so i had to delay replying to you until now. I have some questions that have been added to the review. Could you please take some time to reply?

common/webview_handler.cc Outdated Show resolved Hide resolved
common/webview_handler.cc Show resolved Hide resolved
linux/CMakeLists.txt Outdated Show resolved Hide resolved
@SinyimZhi
Copy link
Collaborator

And i didn't quite understand what you meant "since there are no official Linux builds for arm64"? I first started developing this plugin to support Linux by verifying and developing it on an arm64 environment.. My previous project mainly ran on the arm64 version on Linux, and we did indeed develop it on the arm64 environment.

@cadivus
Copy link
Collaborator Author

cadivus commented Oct 22, 2024

And i didn't quite understand what you meant "since there are no official Linux builds for arm64"? I first started developing this plugin to support Linux by verifying and developing it on an arm64 environment.. My previous project mainly ran on the arm64 version on Linux, and we did indeed develop it on the arm64 environment.

In the SDK archive, I just see x64 for Linux:
Screenshot_20241022_215152

(https://docs.flutter.dev/release/archive)

Maybe I missed something. The VM on my M1 Macbook was the first time using Linux on arm64, I just did it for testing my changes and usually don't target it.

@cadivus cadivus requested a review from SinyimZhi October 22, 2024 19:53
@cadivus
Copy link
Collaborator Author

cadivus commented Oct 22, 2024

@SinyimZhi I hope I answered everything. Please check again.

linux/CMakeLists.txt Outdated Show resolved Hide resolved
common/webview_handler.cc Show resolved Hide resolved
common/webview_handler.cc Show resolved Hide resolved
@SinyimZhi
Copy link
Collaborator

And i didn't quite understand what you meant "since there are no official Linux builds for arm64"? I first started developing this plugin to support Linux by verifying and developing it on an arm64 environment.. My previous project mainly ran on the arm64 version on Linux, and we did indeed develop it on the arm64 environment.

In the SDK archive, I just see x64 for Linux: Screenshot_20241022_215152

(https://docs.flutter.dev/release/archive)

Maybe I missed something. The VM on my M1 Macbook was the first time using Linux on arm64, I just did it for testing my changes and usually don't target it.

Juset download the offical sdk and run flutter doctor on arm64 enviroment, flutter sdk can work as well as amd64.

@cadivus
Copy link
Collaborator Author

cadivus commented Oct 23, 2024

Juset download the offical sdk and run flutter doctor on arm64 enviroment, flutter sdk can work as well as amd64.

That's the first thing I tried, didn't work. But I think it doesn't matter here.

@cadivus cadivus requested a review from SinyimZhi October 23, 2024 13:48
@cadivus
Copy link
Collaborator Author

cadivus commented Oct 23, 2024

@SinyimZhi Please have a look again.

@SinyimZhi SinyimZhi merged commit 28f0de5 into hlwhl:main Oct 24, 2024
@SinyimZhi
Copy link
Collaborator

@SinyimZhi Please have a look again.

Great work, thank you for your contribution. If you are interested, you are welcome to participate in more of this project.

@cadivus
Copy link
Collaborator Author

cadivus commented Oct 24, 2024

@SinyimZhi Thanks for Integrating my code, I probably will.
Could you please trigger a release to pub.dev?

@cadivus cadivus deleted the fix_linux branch October 24, 2024 23:04
@cadivus
Copy link
Collaborator Author

cadivus commented Oct 24, 2024

@SinyimZhi Thanks for Integrating my code, I probably will. Could you please trigger a release to pub.dev?

@SinyimZhi You can wait with that, one of the other PRs you merged broke Linux again...
I'm on it incl a Github workflow checking Linux builds.

@cadivus
Copy link
Collaborator Author

cadivus commented Oct 25, 2024

@SinyimZhi I fixed these errors here:
#157

After merging that, it would be nice if you could push a new version on pub.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants