-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Linux builds and upgrade CEF #148
Conversation
I will check it in the next few day. |
@SinyimZhi This is the Flutter build I used in the arm64 VM since there are no official Linux builds for arm64: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making some amazing contributions. Due to some recent work and family matters, I don't have much energy to focus on this project, so i had to delay replying to you until now. I have some questions that have been added to the review. Could you please take some time to reply?
And i didn't quite understand what you meant "since there are no official Linux builds for arm64"? I first started developing this plugin to support Linux by verifying and developing it on an arm64 environment.. My previous project mainly ran on the arm64 version on Linux, and we did indeed develop it on the arm64 environment. |
In the SDK archive, I just see x64 for Linux: (https://docs.flutter.dev/release/archive) Maybe I missed something. The VM on my M1 Macbook was the first time using Linux on arm64, I just did it for testing my changes and usually don't target it. |
@SinyimZhi I hope I answered everything. Please check again. |
Juset download the offical sdk and run flutter doctor on arm64 enviroment, flutter sdk can work as well as amd64. |
That's the first thing I tried, didn't work. But I think it doesn't matter here. |
@SinyimZhi Please have a look again. |
Great work, thank you for your contribution. If you are interested, you are welcome to participate in more of this project. |
@SinyimZhi Thanks for Integrating my code, I probably will. |
@SinyimZhi You can wait with that, one of the other PRs you merged broke Linux again... |
@SinyimZhi I fixed these errors here: After merging that, it would be nice if you could push a new version on pub.dev |
Hi!
On Ubuntu 24.04, builds fail (see build_errors.txt).
This is my toolchain:
This PR fixes that and upgrades CEF by using offical builds (https://github.com/chromiumembedded/cef?tab=readme-ov-file#quick-links).