Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add values, additional example #9

Merged
merged 1 commit into from
Oct 8, 2022
Merged

Add values, additional example #9

merged 1 commit into from
Oct 8, 2022

Conversation

karlhorky
Copy link
Contributor

Thanks for this plugin @hpersson, really cool! 🙌 I will include it in our configuration for our bootcamp students

Reading through the documentation here, it seems that these uninitialized variables do not actually raise warnings/errors with the plugin - they need to have a type of number or string, either by initializing with a value (like this PR does) or assigning a type.

Also added an example of a number constant that does not raise problems with the plugin.

If you want additional incorrect examples with a TS type annotation, I can add these as well.

@hluisson
Copy link
Owner

hluisson commented Oct 8, 2022

Thanks! These documentation updates look good to me. 👍

@hluisson hluisson merged commit cb612d1 into hluisson:master Oct 8, 2022
@karlhorky
Copy link
Contributor Author

Glad to help :) thanks for the merge!

@karlhorky karlhorky deleted the patch-1 branch October 9, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants