PackageChecksumRules #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I took a quick peek, it looks reasonable. I pulled the branch locally and ran it against my DiscordTimestamp repo and it passed. Here's what it looked like in the debugger:
I suggest adding a note to the readme or something to go along with this rule that says a checksums.txt file can be generated in GitHub workflows using the |
|
Yes, the README should be updated. |
|
@neilenns I updated the README. Does it make sense? |
hlaueriksson
force-pushed
the
checksums
branch
from
0382c71 to
c44df3b
Compare
neilenns
reviewed
Dec 15, 2024
neilenns
reviewed
Dec 15, 2024
neilenns
reviewed
Dec 15, 2024
Co-authored-by: Neil Enns <[email protected]>
Co-authored-by: Neil Enns <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #4