lax

- Filename does not match "<name>-<version>-<platform>.zip" convention
- IcoPathDark missing in package

src/Community.PowerToys.Run.Plugin.Lint/Rules.cs

@@ -192,7 +192,7 @@ public IEnumerable<string> Validate()
         if (!PackageRegex().IsMatch(package.FileInfo.Name)) yield return $"Filename does not match {"<name>-<version>-<platform>.zip".ToQuote()} convention";
     }
 
-    [GeneratedRegex(@"^\w+-\d+\.\d+\.\d+-(arm64|x64)\.zip$")]
+    [GeneratedRegex(@"^(?<name>[\w\.]+)-(?<version>\d+\.\d+\.\d+)-(?<platform>(?i:arm64|x64))\.zip$")]
     private static partial Regex PackageRegex();
 }
 
@@ -258,8 +258,9 @@ public IEnumerable<string> Validate()
 
         string? RootFolder() => package.ZipArchive.Entries.Select(x => x.FullName.Split('\\', '/')[0]).Distinct().FirstOrDefault();
         string? GetFilenameVersion() => FilenameVersionRegex().Match(package.FileInfo.Name).Value;
-        bool Exists(string path) => package.ZipArchive.Entries.Any(x => x.FullName.EndsWith(path, StringComparison.Ordinal));
+        bool Exists(string path) => package.ZipArchive.Entries.Any(x => NormalizePath(x.FullName).EndsWith(NormalizePath(path), StringComparison.Ordinal));
         bool DynamicLoadingUnnecessary(bool enabled) => enabled && package.ZipArchive.Entries.Count(x => x.Name.EndsWith(".dll", StringComparison.Ordinal)) == 1;
+        string NormalizePath(string path) => path.Replace('\\', '/');
     }
 
     [GeneratedRegex(@"(\d+\.\d+\.\d+)")]

tests/Community.PowerToys.Run.Plugin.Lint.Tests/RulesTests.cs

@@ -162,6 +162,9 @@ public void PackageRules_should_validate_Package()
 
             subject = new PackageRules(new(new(), @"..\..\..\Packages\Valid-0.82.1-x64.zip"));
             subject.Validate().Clean().Should().BeEmpty();
+
+            subject = new PackageRules(new(new(), @"..\..\..\Packages\Valid.Name-0.82.1-X64.zip"));
+            subject.Validate().Clean().Should().BeEmpty();
         }
 
         [Test]
@@ -264,6 +267,11 @@ public void PluginMetadataRules_should_validate_Package()
             subject = new PluginMetadataRules(package, repository);
             subject.Validate().Clean().Should().BeEmpty();
 
+            package = new Package(new(), @"..\..\..\Packages\ValidZipPathsWithSlash-0.82.1-x64.zip");
+            package.Load();
+            subject = new PluginMetadataRules(package, repository);
+            subject.Validate().Clean().Should().BeEmpty();
+
             static void SetMetadata(Package package, Metadata metadata)
             {
                 var property = package.GetType().GetProperty(nameof(Package.Metadata));