Updated UI for the NGO page #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for re-commiting the files related to "about" page as the branch we were working upon was not up-to-date initially. |
| @@ -28,6 +28,7 @@ a:hover { | |||
| font-size: 16px; | |||
| line-height: 38px; | |||
| margin: 0; | |||
|
|
|||
|
I checked a few files. You have added so many unnecessary files. When you copy templates online, make sure you know why you are using them. I will review rest once you fix your commit by removing unused files. |
|
@hkasera I apologize for the wrong commit. All the unnecessary files have been removed. Kindly review the PR. |
| <ul class="sidebar-nav"> | ||
| <a id="menu-close" href="#" class="btn btn-light btn-lg pull-right toggle"><i class="fa fa-times"></i></a> | ||
| <li class="sidebar-brand"> | ||
| <a href="#top" onclick = $("#menu-close").click(); >We Care</a> |
|
The current UI has a lot of white space. The images are of varied sizes which does not look good. See if you can come up with a better UI. Also, as I mentioned before try to create a rough diagram in a paper before actually writing the HTML. Also, get the rough thing reviewed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #8
The UI of the "NGO page" i.e. the page that displays information related to a specific NGO has been updated.
Bootstrap has been used for better styling. All the bootstrapping content (including scripts, stylesheets and images) have been including in the "ngo_bootstrap" folder.
Attached screenshots
1.) Main view of the page.
2.) Sidebar wrapper
3.) Short description of NGO and its associated campaigns
4.) Contact Information
@hkasera Kindly review the PR and provide your valuable feedback.
Thanks