Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(util): do not consume leading slash #13

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix(util): do not consume leading slash #13

merged 1 commit into from
Jul 23, 2024

Conversation

CameronNemo
Copy link
Contributor

Closes #12

@CameronNemo CameronNemo force-pushed the close-12 branch 2 times, most recently from d998a1f to e3c5da2 Compare December 8, 2019 01:23
Dzordzu
Dzordzu approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@Dzordzu Dzordzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As of now I cannot see potential downsides

@trobro trobro merged commit a529713 into hjson:master Jul 23, 2024
2 checks passed
@trobro
Copy link
Member

trobro commented Jul 23, 2024

Thanks for the contribution, sorry for the small delay in merging...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dzordzu Dzordzu Dzordzu approved these changes

@shi-yan shi-yan shi-yan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strips leading slashes from key names and string fields
4 participants
@CameronNemo @trobro @shi-yan @Dzordzu