Refactor commands using mixins and add testsuite #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitseti
force-pushed
the
refactor-commands-using-mixins
branch
from
de7fe40 to
d38f54b
Compare
Aligned version and help options. Removed unnecessary inheritance. Fixed minor printout issues. Improved native image code documentation. Code refactoring.
…into refactor-commands-using-mixins
…tor-commands-using-mixins # Conflicts: # src/main/java/com/hivemq/cli/commands/AbstractCommonFlags.java # src/main/java/com/hivemq/cli/commands/cli/PublishCommand.java # src/main/java/com/hivemq/cli/commands/options/ConnectRestrictionOptions.java # src/main/java/com/hivemq/cli/commands/options/WillOptions.java # src/main/java/com/hivemq/cli/commands/shell/ContextPublishCommand.java # src/main/java/com/hivemq/cli/commands/shell/ListClientsCommand.java # src/main/java/com/hivemq/cli/mqtt/MqttClientExecutor.java # src/systemTest/java/com/hivemq/cli/commands/cli/PublishST.java # src/systemTest/java/com/hivemq/cli/commands/cli/SubscribeST.java # src/systemTest/java/com/hivemq/cli/commands/cli/shell/ConnectST.java # src/systemTest/java/com/hivemq/cli/commands/cli/shell/DisconnectST.java # src/systemTest/java/com/hivemq/cli/commands/cli/shell/PublishST.java # src/systemTest/java/com/hivemq/cli/commands/cli/shell/SubscribeST.java
Fixed native image. Aligned code formatting.
ghost
marked this pull request as ready for review
ghost
mentioned this pull request
Closed
ghost
changed the title
ghost
self-assigned this
|
This pull request was pair-programmed with @gitseti and the testsuite was written to ensure all commands are still functional after this huge change. |
ghost
approved these changes
Dec 22, 2022
…into refactor-commands-using-mixins
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://hivemq.kanbanize.com/ctrl_board/22/cards/6612/details/
resolves #147