Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug: #123

Merged
merged 2 commits into from
Jan 15, 2020
Merged

fix a bug: #123

merged 2 commits into from
Jan 15, 2020

Conversation

xiefeifeihu
Copy link
Contributor

Motivation

When config auth.server.cafile in config.properties,Command Line doesn't take effect.It also need to add --cafile in command line.

Now I fix the bug.We Can specify the CA certificate both in config.properties and command line.

Changes
add line 83 in DefaultCLIProperties.java----put(SERVER_CERTIFICATE, null);
add line 142 to 144 in AbstractCommonFlags.java----initialize certificates collection

When config auth.server.cafile in config.properties,Command Line doesn't take effect.It also need to add --cafile in command line.

Now I fix the bug.We Can specify the CA certificate both in config.properties and command line.
@xiefeifeihu xiefeifeihu requested a review from gitseti as a code owner January 6, 2020 07:23
@schaebo
Copy link
Member

schaebo commented Jan 7, 2020

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Jan 7, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @xiefeifeihu on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

@cla-bot
Copy link

cla-bot bot commented Jan 7, 2020

The cla-bot has been summoned, and re-checked this pull request!

@gitseti
Copy link
Contributor

gitseti commented Jan 15, 2020

Thanks for the contribution, @xiefeifeihu!

Please sign the Contributor License Agreement (https://www.hivemq.com/downloads/Contributor_License_Agreement.pdf) and send it to [email protected] so we can merge your requested changes.

@xiefeifeihu
Copy link
Contributor Author

Thanks for the contribution, @xiefeifeihu!

Please sign the Contributor License Agreement (https://www.hivemq.com/downloads/Contributor_License_Agreement.pdf) and send it to [email protected] so we can merge your requested changes.

I have already sent the pdf on January 8th.I send again a few minute ago.Please check your email.
20200115170501

@gitseti
Copy link
Contributor

gitseti commented Jan 15, 2020

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Jan 15, 2020

The cla-bot has been summoned, and re-checked this pull request!

@cla-bot cla-bot bot added the cla-signed label Jan 15, 2020
@gitseti gitseti merged commit 59ba36a into hivemq:develop Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants