-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add password input from environment variable and file #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitseti
changed the title
Feature/add more password inputs #103
Add password input from environment variable and file
Oct 27, 2019
SgtSilvio
reviewed
Nov 5, 2019
src/main/java/com/hivemq/cli/converters/FileToByteBufferConverter.java
Outdated
Show resolved
Hide resolved
SgtSilvio
reviewed
Nov 5, 2019
src/main/java/com/hivemq/cli/converters/EnvVarToByteBufferConverter.java
Show resolved
Hide resolved
SgtSilvio
requested changes
Nov 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only remark is the file to string to bytebuffer conversion
SgtSilvio
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
resolve #103
Most of the time it is not a best practice to read in passwords in the command line in clear text like
mqtt> con -i myClient -u gitseti -pw mypassword
. Therefore, it is already possible to omit the password text so that the cli will prompt the user to enter the password in a masked input field.Nevertheless, this input field shows some limitations (like the input being kept to a specific internal buffer size) so that another option for securely reading in a password is needed.
Therefore, this PR introduces two new sources for password input:
These options can be specified in
con
,mqtt pub
andmqtt sub
as follows:Changes