Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid DNS lookup if provided an IPv4 or IPv6 #221

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

JaggerJo
Copy link
Contributor

Description

see issue #220

In short: Skip the DNS lookup if an IP was provided as Host.

Related Issue

#220
#216

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've written tests (if applicable) for all new methods and classes that I created. (rake test)
  • I've added documentation as necessary so users can easily use and understand this feature/fix.

Copy link

cla-bot bot commented Jan 16, 2025

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @JaggerJo on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

@JaggerJo
Copy link
Contributor Author

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @JaggerJo on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

✅ done

@pglombardo
Copy link
Collaborator

Thanks @JaggerJo! Let me work out the CLA bot issues and I'll aim to merge right afterwards.

@JaggerJo
Copy link
Contributor Author

Thanks @JaggerJo! Let me work out the CLA bot issues and I'll aim to merge right afterwards.

Thanks @pglombardo !

Could you also take a look at:

@sauroter
Copy link
Member

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Jan 17, 2025
Copy link

cla-bot bot commented Jan 17, 2025

The cla-bot has been summoned, and re-checked this pull request!

@pglombardo
Copy link
Collaborator

Thanks @JaggerJo! This will go out in the next release.

@pglombardo pglombardo changed the title prefer IP when provided Avoid DNS lookup if provided an IP Jan 20, 2025
@pglombardo pglombardo changed the title Avoid DNS lookup if provided an IP Avoid DNS lookup if provided an IPv4 or IPv6 Jan 20, 2025
@pglombardo pglombardo merged commit 360ffc9 into hivemq:main Jan 20, 2025
10 checks passed
@pglombardo
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants