Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address vulnerabilities #70

Closed
wants to merge 2 commits into from

Conversation

jssuttles
Copy link

@jssuttles jssuttles commented Dec 17, 2021

Updated all the packages.
Replaced watch (which is not maintained mikeal/watch#149) with chokidar

fix: replace watch with chokidar
@hitgeek
Copy link
Owner

hitgeek commented Dec 18, 2021

do the tests pass for you locally? I am unable to get the tests to pass.

Note: watch dependency is removed in v4, you can get that from npm via simple-hl7@next .... I haven't had much time to test so that version is still considered beta. there are also going to be some breaking changes in v4 to better align with the hl7 spec, but I haven't got around to those yet.

@hitgeek
Copy link
Owner

hitgeek commented Dec 18, 2021

@jssuttles would this work for you. #71

@Djeisen642
Copy link

The tests worked for me. I'll have to get back around to looking at it maybe later today. (What do you see when they fail? I'm not too familiar with what failure looks like in this set of tests.)

If you're refactoring the system, then I don't mind waiting for the package to get stable. I was just trying to help get this vulnerable package out of this repo.

I'm not personally a fan of copying code out of a package, because you lose all the tests that might have been in place with that package.

@jssuttles
Copy link
Author

I see. Now I see the tests not passing. I'll see what I can do.

@jssuttles
Copy link
Author

Perhaps the file was not fully written, and therefore there were inconsistent test results?

@jssuttles jssuttles closed this Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants