Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Rook/Ceph storage #3002

Merged
merged 33 commits into from
Apr 20, 2022
Merged

Feature Rook/Ceph storage #3002

merged 33 commits into from
Apr 20, 2022

Conversation

erzetpe
Copy link
Contributor

@erzetpe erzetpe commented Mar 1, 2022

No description provided.

@erzetpe erzetpe force-pushed the feature/rook-ceph-storage branch 2 times, most recently from e16d404 to 0347086 Compare March 3, 2022 10:54
ansible/playbooks/roles/rook/tasks/main.yml Outdated Show resolved Hide resolved
ansible/playbooks/roles/rook/tasks/main.yml Outdated Show resolved Hide resolved
ansible/playbooks/roles/rook/tasks/main.yml Outdated Show resolved Hide resolved
ansible/playbooks/rook.yml Show resolved Hide resolved
ansible/playbooks/rook.yml Outdated Show resolved Hide resolved
schema/common/defaults/configuration/rook.yml Show resolved Hide resolved
docs/changelogs/CHANGELOG-2.0.md Show resolved Hide resolved
@erzetpe erzetpe force-pushed the feature/rook-ceph-storage branch from bcf0a3c to 42439d4 Compare March 8, 2022 07:51
Copy link
Contributor

@rafzei rafzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erzetpe could you please, run ansible-lint in devcontainer on the rook playbook and fix the issues(5)?

ansible/playbooks/roles/rook/tasks/main.yml Outdated Show resolved Hide resolved
@erzetpe
Copy link
Contributor Author

erzetpe commented Mar 8, 2022

@rafzei I have marked as false positives two files permissions from temporary config files with no sensitive data. We need to create task to fix linter issues from other roles.

rafzei
rafzei previously approved these changes Mar 8, 2022
seriva
seriva previously approved these changes Mar 9, 2022
rafzei
rafzei previously approved these changes Mar 9, 2022
seriva
seriva previously approved these changes Mar 10, 2022
@erzetpe erzetpe dismissed stale reviews from seriva and rafzei via c3ebb6a March 22, 2022 07:24
@erzetpe erzetpe force-pushed the feature/rook-ceph-storage branch from ce61cf9 to c3ebb6a Compare March 22, 2022 07:24
seriva
seriva previously approved these changes Mar 24, 2022
@seriva seriva requested a review from rafzei March 24, 2022 12:25
@erzetpe erzetpe force-pushed the feature/rook-ceph-storage branch from c3ebb6a to 6779e6b Compare April 4, 2022 08:30
@przemyslavic
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cicharka cicharka force-pushed the feature/rook-ceph-storage branch from 8351e57 to f67652d Compare April 14, 2022 06:12
@seriva seriva requested review from seriva and przemyslavic April 15, 2022 08:00
seriva
seriva previously approved these changes Apr 15, 2022
@przemyslavic
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@przemyslavic
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

* enahnce playbook to allow chart files use images from
  local image registry
* remove unused condition for chart and operator specification
  which is always defined now
* modify path for rook/ceph image in order to be compliant
  with values.yml

Signed-off-by: cicharka <[email protected]>
@cicharka cicharka force-pushed the feature/rook-ceph-storage branch from 3137734 to 73e6e99 Compare April 15, 2022 09:20
@przemyslavic
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@przemyslavic
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cicharka cicharka force-pushed the feature/rook-ceph-storage branch from bb41d38 to bf75117 Compare April 15, 2022 11:22
@przemyslavic
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cicharka cicharka force-pushed the feature/rook-ceph-storage branch from bf75117 to 662d7cd Compare April 15, 2022 11:25
@przemyslavic
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@seriva seriva self-requested a review April 20, 2022 08:05
@erzetpe erzetpe merged commit bf36a7f into develop Apr 20, 2022
@erzetpe erzetpe deleted the feature/rook-ceph-storage branch April 20, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants