Change Grafana admin password in the apply mode (#2420) #2819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafzei
reviewed
Dec 28, 2021
ansible/playbooks/roles/grafana/tasks/upgrade/password_change.yml
Outdated
Show resolved
Hide resolved
atsikham
reviewed
Dec 28, 2021
sbbroot
force-pushed
the
grafana-password-change
branch
from
dcc7b62 to
7391ba6
Compare
atsikham
suggested changes
Dec 29, 2021
erzetpe
suggested changes
Dec 30, 2021
sbbroot
force-pushed
the
grafana-password-change
branch
from
7391ba6 to
549a9cf
Compare
atsikham
suggested changes
Jan 3, 2022
atsikham
changed the title
atsikham
previously approved these changes
Jan 4, 2022
erzetpe
previously approved these changes
Jan 4, 2022
|
/azp run |
seriva
previously approved these changes
Jan 5, 2022
erzetpe
previously approved these changes
Jan 5, 2022
|
@sbbroot During an upgrade with -f and new password in specification.grafana_security.admin_password, grafana.ini wasn't updated. 4/32 tests failed. I see vars in build dir were updated as expected. grafana_security:
admin_user: admin
admin_password: newpassword |
I suppose that for the |
sbbroot
force-pushed
the
grafana-password-change
branch
from
cc8e896 to
0c745a1
Compare
|
@sbbroot please add a comment on why you decided to do not to implement it in the upgrade procedure. |
|
I've tested apply-> re-apply and looks fine. |
atsikham
approved these changes
Jan 12, 2022
rafzei
approved these changes
Jan 12, 2022
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.