Upgrade JMX exporter to the newest version (#2750) #2779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cicharka
force-pushed
the
feature/jmx_exporter
branch
2 times, most recently
from
9355ac6 to
cc857ed
Compare
erzetpe
suggested changes
Dec 9, 2021
cicharka
force-pushed
the
feature/jmx_exporter
branch
from
d0d0e52 to
1bd3987
Compare
* requirements changed to use jmx_exporter ver 0.16.1 * upgrade play for jmx_exporter added * added new component for upgrade in cli * docs updated * minor whitespaces removal Signed-off-by: cicharka <[email protected]>
* prometheus_jmx_path removed from schema for roles: kafka and jmx-exporter and moved to defaults for these roles * unification of name that was holding symlink path for Prometheus JMX exporter binary, used by roles: kafka, jmx-exporter, zookeeper Justification: Path to symbolic link to JMX exporter binary should not be managed by the user since he is not responsible for binary download and configuration of prometheus scraper. Signed-off-by: cicharka <[email protected]>
* Introduced upgrade flag file * preflight check for binary existance and version downgrade Changes are based on result of discussion on upgrade approach and are following convention used in 'Upgrade Kafka Exporter to v1.4.2 hitachienergy#2772'. Signed-off-by: cicharka <[email protected]>
cicharka
force-pushed
the
feature/jmx_exporter
branch
from
1bd3987 to
0de13fb
Compare
plirglo
approved these changes
Dec 10, 2021
erzetpe
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade JMX exporter to version 0.16.1
Move prometheus_jmx_path from schema to defaults:
jmx-exporter and moved to defaults for these roles
binary, used by roles: kafka, jmx-exporter, zookeeper
Justification:
Path of symbolic link to JMX exporter binary should not be managed by
the user since he is not responsible for binary download and
configuration of prometheus scrape