Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RabbitMQ monitoring (#1487) #2603

Merged
merged 2 commits into from
Sep 30, 2021
Merged

RabbitMQ monitoring (#1487) #2603

merged 2 commits into from
Sep 30, 2021

Conversation

sbbroot
Copy link
Contributor

@sbbroot sbbroot commented Sep 22, 2021

  • Add Grafana dashboards for RabbitMQ monitoring

atsikham
atsikham reviewed Sep 22, 2021
View reviewed changes
Copy link
Contributor

@atsikham atsikham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but conflicts need to be resolved.

@sbbroot
RabbitMQ monitoring (hitachienergy#1487)
283f60b 
* Add Grafana dashboards for RabbitMQ monitoring
@sbbroot sbbroot force-pushed the grafana-dashboards-rabbitmq branch from bb3bc01 to 283f60b Compare September 22, 2021 17:22
rafzei
rafzei suggested changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@rafzei rafzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update table with license for this dashboard, here

core/src/epicli/data/common/defaults/configuration/grafana.yml Outdated Show resolved Hide resolved
@sbbroot
* add dashboard license
acc7487 
* remove useless comment
@seriva
Copy link
Collaborator

seriva commented Sep 30, 2021

Merged as per @przemyslavic permission as we want todo #2643 ASAP. He will test it from develop.

@seriva seriva merged commit ce97e63 into hitachienergy:develop Sep 30, 2021
@sbbroot sbbroot deleted the grafana-dashboards-rabbitmq branch May 5, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atsikham atsikham atsikham left review comments

@rafzei rafzei rafzei approved these changes

@seriva seriva seriva approved these changes

@erzetpe erzetpe erzetpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sbbroot @seriva @erzetpe @atsikham @rafzei