[Reverted] add logrotate config for pgbouncer and filebeat input #921 #1823
Conversation
ar3ndt
changed the title
| enabled: true | ||
| paths: | ||
| - /var/log/pgbouncer/*.log* | ||
| exclude_files: [".gz$"] | ||
| {% endif %} |
There was a problem hiding this comment.
Please add a posibility to use multiline for pgbouncer as well. Dont forget about update docs. Thanks.
There was a problem hiding this comment.
Pgbouncer logs do not seem to generate multilines. Do you think it is neccessary anyways then?
There was a problem hiding this comment.
Hmm I don't know the structure of pgbouncer logs. It would be good to have this as an option (not enabled by default) as we already provided it for postgresql logs. So maybe let's involve someone else in discussion.
There was a problem hiding this comment.
I've checked on Ubuntu, there is no any multi-line entry in log, even after changing verbose = 0 to verbose = 2.
core/src/epicli/data/common/defaults/configuration/postgresql.yml
Outdated
Show resolved
Hide resolved
|
IDK if someone is going to review that, but for me it's ok to add multiline support later when/if it will be necessary. |
core/src/epicli/data/common/ansible/playbooks/roles/filebeat/templates/filebeat.yml.j2
Show resolved
Hide resolved
| copytruncate | ||
| size 10M | ||
| daily | ||
| create 0640 pgbouncer pgbouncer |
There was a problem hiding this comment.
On Ubuntu we do not have such user:
id pgbouncer
id: ‘pgbouncer’: no such user
| create 0640 pgbouncer pgbouncer | ||
| nodateext | ||
| postrotate | ||
| /bin/kill -HUP cat /run/pgbouncer/pgbouncer.pid 2>/dev/null 2> /dev/null || true |
There was a problem hiding this comment.
On Ubuntu the pidfile path is different:
grep pidfile /etc/pgbouncer/pgbouncer.ini
pidfile = /var/run/postgresql/pgbouncer.pid
| @@ -121,3 +121,16 @@ specification: | |||
| # to have multiple unique filenames per day when dateext option is set | |||
| dateformat -%Y%m%dH%H | |||
| } | |||
| /var/log/pgbouncer/pgbouncer.log { | |||
There was a problem hiding this comment.
On RHEL there is already existing configuration in /etc/logrotate.d/pgbouncer so this one duplicates it.
|
Guise, pls take into account @to-bar 's review and create another PR with fixes. 🙄 |
|
This PR has to be rewritten so I decided to revert it. See comments. |
to-bar
changed the title
… (hitachienergy#1823) * add logrotate config for pgbouncer and filebeat input
… (hitachienergy#1823) * add logrotate config for pgbouncer and filebeat input
No description provided.