Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kafka 2.6.0 #1790

Closed

Conversation

sunshine69
Copy link
Contributor

No description provided.

@sunshine69
Copy link
Contributor Author

This has been a request #1137 and we are currently suffering from this kafka for too long.

@sunshine69
Copy link
Contributor Author

Please note that I have tested this PR and successfully build a epiph cluster with kafka version 2.6.0.

From the original request (not mine) I saw that we are not planned for 0.8.0 but it is not clear to me the reason. Can someone please share a bit more about it? I would like to know what is the technical issues, or procedure issues that prevent us to move forward?

Thanks

@seriva
Copy link
Collaborator

seriva commented Oct 23, 2020

Hey

Few minor comments:

Few bigger things:

  • Missing upgrade for existing clusters, this will break existing installations.
  • We need to check Zookeeper as well. If I remember there are some issues regarding compatibility or do we even still need it? (Upgrade ZooKeeper #1136)

Cheers
Luuk

@sunshine69
Copy link
Contributor Author

Thanks Luuk, I will look into it as soon as I can

@sunshine69
Copy link
Contributor Author

@seriva Are we meant to support upgrade for kafka? To my best of knowledge we don't support it even for current - it is complex process.

Re-run epiphany and update component is still a test/try progress atm and depending on many components, some might work, some might not. I saw a page somewhere listing state of it and I remember we mostly don't support it globally. Am I correct?

I will try to look into upgrade as well by the way admiting it would be very complex situation .

@seriva
Copy link
Collaborator

seriva commented Nov 3, 2020

@sunshine69 Sorry for the late reply but yes this upgrade should be taken into consideration looking at the issue Tomasz made for that #1137

image

Otherwise existing cluster might have issues.

@plirglo
Copy link
Contributor

plirglo commented Nov 3, 2020

Hi @sunshine69

As @seriva mentioned while changing version of component we should also create automation to upgrade this component (by running epicli upgrade).

To see how it was done for upgrade between Kafka 2.0.0 to recent 2.3.1 please look at this part of upgrade code here and ansible tasks located here.

Also with Kafka 2.6 Apache released new version of Zookeeper here, so in this case we should also upgrade Zookeeper to keep configuration consistent.

Regards,
Irek

https://repo1.maven.org/maven2/io/prometheus/jmx/jmx_prometheus_javaagent/0.12.0/jmx_prometheus_javaagent-0.12.0.jar
https://archive.apache.org/dist/kafka/2.3.1/kafka_2.12-2.3.1.tgz
https://repo1.maven.org/maven2/io/prometheus/jmx/jmx_prometheus_javaagent/0.14.0/jmx_prometheus_javaagent-0.14.0.jar
http://apache.mirror.amaze.com.au/kafka/2.6.0/kafka_2.12-2.6.0.tgz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you have chosen this mirror?

https://repo1.maven.org/maven2/io/prometheus/jmx/jmx_prometheus_javaagent/0.12.0/jmx_prometheus_javaagent-0.12.0.jar
https://archive.apache.org/dist/kafka/2.3.1/kafka_2.12-2.3.1.tgz
https://repo1.maven.org/maven2/io/prometheus/jmx/jmx_prometheus_javaagent/0.14.0/jmx_prometheus_javaagent-0.14.0.jar
http://apache.mirror.amaze.com.au/kafka/2.6.0/kafka_2.12-2.6.0.tgz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you have chosen this mirror?

@atsikham
Copy link
Contributor

atsikham commented Dec 4, 2020

This PR seems to be ok as we already do Zookeeper upgrade in another task and there is Kafka upgrade part in upgrade role, but @erzetpe questions still have no answers and there are no components/changelog updates. We support only offline upgrade and I see no changes to make there.

@toszo toszo mentioned this pull request Dec 6, 2020
@atsikham
Copy link
Contributor

atsikham commented Dec 8, 2020

@toszo so this PR can be closed as implemented in #1890?

@toszo toszo closed this Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants