Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haproxy upgrade (epicli) #1619

Merged
merged 11 commits into from
Sep 14, 2020

Conversation

sk4zuzu
Copy link
Contributor

@sk4zuzu sk4zuzu commented Sep 3, 2020

#1586 should be merged first, then this one rebased and reviewed 👍

@sk4zuzu sk4zuzu force-pushed the feature/haproxy-epicli-upgrade branch from dc3126e to c9bd77b Compare September 4, 2020 06:58
@sk4zuzu sk4zuzu force-pushed the feature/haproxy-epicli-upgrade branch from c9bd77b to ded665b Compare September 10, 2020 13:25
@sk4zuzu sk4zuzu marked this pull request as ready for review September 10, 2020 13:28
Copy link
Contributor

@atsikham atsikham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but with a few questions, will be approved then

atsikham
atsikham previously approved these changes Sep 11, 2020
atsikham
atsikham previously approved these changes Sep 13, 2020
@atsikham atsikham mentioned this pull request Sep 13, 2020
rafzei
rafzei previously approved these changes Sep 14, 2020
Copy link
Contributor

@rafzei rafzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I see no docs update (components,changelog etc..)

@sk4zuzu sk4zuzu dismissed stale reviews from rafzei and atsikham via 318eea8 September 14, 2020 08:23
@sk4zuzu
Copy link
Contributor Author

sk4zuzu commented Sep 14, 2020

LGTM but I see no docs update (components,changelog etc..)

@rafzei, please re-check now. I added components, changelog and some info how to expose k8s service (it was TODO previously).

Copy link
Contributor

@rafzei rafzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants