-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Haproxy upgrade (epicli) #1619
Haproxy upgrade (epicli) #1619
Conversation
dc3126e
to
c9bd77b
Compare
c9bd77b
to
ded665b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but with a few questions, will be approved then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I see no docs update (components,changelog etc..)
@rafzei, please re-check now. I added components, changelog and some info how to expose k8s service (it was TODO previously). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks.
#1586 should be merged first, then this one rebased and reviewed 👍