Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide possibility to change additional parameters in default kafka configuration #1329

Closed
erzetpe opened this issue Jun 3, 2020 · 4 comments · Fixed by #1529
Closed

Provide possibility to change additional parameters in default kafka configuration #1329

erzetpe opened this issue Jun 3, 2020 · 4 comments · Fixed by #1529

Comments

@erzetpe
Copy link
Contributor

erzetpe commented Jun 3, 2020

Describe the bug:
Additional Kafka parameters such as:

  • max.incremental.fetch.session.cache.slots
  • controlled.shutdown.enable
  • default.replication.factor
  • offsets.topic.replication.factor

are not configurable in Epiphany configuration. It is not possible to override the default values.

Expected behavior
Possibility to change additional Kafka parameters and successfully deployed cluster with the changed parameters.

OS (please complete the following information):

  • OS: [all]

Cloud Environment (please complete the following information):

  • Cloud Provider [e.g. AWS/Azure]
@KWReidABB
Copy link

Things like replication factors should be set automatically by Epiph. If I'm setting up an environment that has 3 Kafka nodes, Epiph should set up these options in the Kafka server.properties file to use those 3 nodes to replicate partitions across the nodes.

Some of the other options should just have their defaults changed to more appropriate values for defaults, and allow override in config file if needed.

@seriva
Copy link
Collaborator

seriva commented Jun 17, 2020

I would suggest the (Default) replication factors should only be set by epiphany to the nr of brokers if the config is not defined in the YAML. It might not always be preferred to set the default to the nr of brokers.

As for the rest of the options, we should check server.properties and see what else might be worth exposing as now some projects are making changes straight to the config after Epiphany installation to meet there needs.

@erzetpe
Copy link
Contributor Author

erzetpe commented Jul 10, 2020

I would stick to defaults that we have right now and make those options configurable. You are setting them after some performance tests and configuration for each user can be different and those settings could have impact on their deployments.

@rpudlowski93
Copy link
Contributor

After the small conversation with @KWReidABB, I can confirm that sticking the defaults values and make those option configurable is enough.

@ar3ndt ar3ndt self-assigned this Aug 4, 2020
@ar3ndt ar3ndt linked a pull request Aug 5, 2020 that will close this issue
ar3ndt added a commit that referenced this issue Aug 7, 2020
@mkyc mkyc added this to the S20200813 milestone Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants