-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide possibility to change additional parameters in default kafka configuration #1329
Comments
Things like replication factors should be set automatically by Epiph. If I'm setting up an environment that has 3 Kafka nodes, Epiph should set up these options in the Kafka server.properties file to use those 3 nodes to replicate partitions across the nodes. Some of the other options should just have their defaults changed to more appropriate values for defaults, and allow override in config file if needed. |
I would suggest the (Default) replication factors should only be set by epiphany to the nr of brokers if the config is not defined in the YAML. It might not always be preferred to set the default to the nr of brokers. As for the rest of the options, we should check server.properties and see what else might be worth exposing as now some projects are making changes straight to the config after Epiphany installation to meet there needs. |
I would stick to defaults that we have right now and make those options configurable. You are setting them after some performance tests and configuration for each user can be different and those settings could have impact on their deployments. |
After the small conversation with @KWReidABB, I can confirm that sticking the defaults values and make those option configurable is enough. |
additional defaults for kafka config #1329
Describe the bug:
Additional Kafka parameters such as:
are not configurable in Epiphany configuration. It is not possible to override the default values.
Expected behavior
Possibility to change additional Kafka parameters and successfully deployed cluster with the changed parameters.
OS (please complete the following information):
Cloud Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: