Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix external packages | fix text editor #72
fix external packages | fix text editor #72
Changes from all commits
a6d8f2b
2c56cde
329d213
f1ff9ba
7840faa
82ff757
7d4fec1
89866bf
03f9d3f
ee36747
abcb63e
81052cb
b74caeb
00b41cb
2eacffc
055f6dd
9b34d7e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The refactoring of the class bindings improves readability by separating the conditions more clearly. However, ensure that the logic for class assignment is thoroughly tested, especially since the use of
!important
in class names (!bg-oc-error
,!border-oc-error
) can lead to CSS specificity issues that might override other styles unintentionally. It's generally best to avoid!important
where possible and rely on a well-structured CSS specificity hierarchy.This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
readImage
function directly sets thebase64
image source into the editor's HTML. This could be a potential security risk if the base64 string is not properly sanitized. Ensure that the base64 string is validated against a known safe pattern before inserting it into the DOM.