Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Open in new tab (fix #52) #59

Merged
merged 3 commits into from
Mar 22, 2022
Merged

feat: Open in new tab (fix #52) #59

merged 3 commits into from
Mar 22, 2022

Conversation

hugoattal
Copy link
Collaborator

fix #52

Description

I refacto a bit some files to spread into several components, other than that it's just a link to open the sandbox into a new tab.

Additional context

image

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@hugoattal hugoattal added the enhancement New feature or request label Mar 20, 2022
@hugoattal hugoattal requested a review from Akryum March 20, 2022 22:45
@hugoattal hugoattal self-assigned this Mar 20, 2022
@netlify
Copy link

netlify bot commented Mar 20, 2022 •
edited
Loading

✅ Deploy Preview for histoire-examples-vue3 ready!

🔨 Explore the source changes: ff84e60

🔍 Inspect the deploy log: https://app.netlify.com/sites/histoire-examples-vue3/deploys/6239e76464114e00087879fd

😎 Browse the preview: https://deploy-preview-59--histoire-examples-vue3.netlify.app

@netlify
Copy link

netlify bot commented Mar 20, 2022 •
edited
Loading

✅ Deploy Preview for histoire-controls ready!

🔨 Explore the source changes: ff84e60

🔍 Inspect the deploy log: https://app.netlify.com/sites/histoire-controls/deploys/6239e7641fb6840008086479

😎 Browse the preview: https://deploy-preview-59--histoire-controls.netlify.app

@netlify
Copy link

netlify bot commented Mar 20, 2022 •
edited
Loading

✅ Deploy Preview for histoire-site ready!

🔨 Explore the source changes: ff84e60

🔍 Inspect the deploy log: https://app.netlify.com/sites/histoire-site/deploys/6239e764d2001e0008d2106e

😎 Browse the preview: https://deploy-preview-59--histoire-site.netlify.app

hugoattal
hugoattal commented Mar 20, 2022
View reviewed changes
pnpm-lock.yaml
@@ -1209,7 +1209,7 @@ packages:
vue:
optional: true
dependencies:
vite: 2.8.6
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, each time I pnpm i, I end up with this modification. Shouldn't it be like that then?

@Akryum Akryum merged commit 93a5095 into main Mar 22, 2022
@Akryum Akryum deleted the open-in-new-tab branch March 22, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akryum Akryum Akryum approved these changes

Assignees

@hugoattal hugoattal

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a button to open the story in a new tab
2 participants
@hugoattal @Akryum