Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Handle files and folders title conflict (fix #57) #58

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

hugoattal
Copy link
Collaborator

fix #57

Description

I ended just making it work, so that the user can still choose whatever name he want.
Files AND folder with the same name "just work".

The conflicting name just have a trailing number to their IDs.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@netlify
Copy link

netlify bot commented Mar 20, 2022

✅ Deploy Preview for histoire-examples-vue3 ready!

🔨 Explore the source changes: 15235ad

🔍 Inspect the deploy log: https://app.netlify.com/sites/histoire-examples-vue3/deploys/6237a84c9678b80008b46c0e

😎 Browse the preview: https://deploy-preview-58--histoire-examples-vue3.netlify.app

@netlify
Copy link

netlify bot commented Mar 20, 2022

✅ Deploy Preview for histoire-controls ready!

🔨 Explore the source changes: 15235ad

🔍 Inspect the deploy log: https://app.netlify.com/sites/histoire-controls/deploys/6237a84cfc67310008e75f14

😎 Browse the preview: https://deploy-preview-58--histoire-controls.netlify.app

@netlify
Copy link

netlify bot commented Mar 20, 2022

✅ Deploy Preview for histoire-site ready!

🔨 Explore the source changes: 15235ad

🔍 Inspect the deploy log: https://app.netlify.com/sites/histoire-site/deploys/6237a84c702de50008503c9a

😎 Browse the preview: https://deploy-preview-58--histoire-site.netlify.app

@hugoattal hugoattal self-assigned this Mar 20, 2022
@hugoattal hugoattal added enhancement New feature or request and removed draft labels Mar 20, 2022
@hugoattal hugoattal requested a review from Akryum March 20, 2022 22:17
@hugoattal hugoattal force-pushed the handle-title-conflict branch from def68bc to 15235ad Compare March 20, 2022 22:18
@Akryum Akryum merged commit 4d21425 into main Mar 22, 2022
@Akryum Akryum deleted the handle-title-conflict branch March 22, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle story title conflict
2 participants