Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Auto expand parent folders of selected story (fix #29) #36

Merged
merged 5 commits into from
Feb 22, 2022
Merged

feat: Auto expand parent folders of selected story (fix #29) #36

merged 5 commits into from
Feb 22, 2022

Conversation

hugoattal
Copy link
Collaborator

@hugoattal hugoattal commented Feb 18, 2022 •
edited
Loading

fix: #29

Description

I used interrobang non-printable char \u0001 File separator unicode symbole to separate paths in the store because I wanted to make folder with slashes work.
cf: https://www.compart.com/fr/unicode/U+241C

Additional context

I would have preferred to use a real Map, but I couldn't make it reactive (with set, get and delete)...

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@hugoattal hugoattal added the enhancement New feature or request label Feb 18, 2022
@hugoattal hugoattal requested a review from Akryum February 18, 2022 16:32
@hugoattal hugoattal self-assigned this Feb 18, 2022
@hugoattal hugoattal changed the title feat: Auto expand parent folders of selected story feat: Auto expand parent folders of selected story (fix #29) Feb 18, 2022
@Akryum
Copy link
Member

Akryum commented Feb 18, 2022

A Map can be reactive: https://sfc.vuejs.org/#eyJBcHAudnVlIjoiPHNjcmlwdCBzZXR1cD5cbmltcG9ydCB7IHJlZiwgY29tcHV0ZWQgfSBmcm9tICd2dWUnXG5cbmNvbnN0IG1zZyA9IHJlZihuZXcgTWFwKCkpXG5tc2cudmFsdWUuc2V0KCdmb28nLCAnYmFyJylcbiAgXG5jb25zdCBlZGl0ID0gY29tcHV0ZWQoe1xuICBnZXQ6ICgpID0+IG1zZy52YWx1ZS5nZXQoJ2ZvbycpLFxuICBzZXQ6IHZhbHVlID0+IG1zZy52YWx1ZS5zZXQoJ2ZvbycsIHZhbHVlKVxufSlcbjwvc2NyaXB0PlxuXG48dGVtcGxhdGU+XG4gIDxoMT57eyBtc2cgfX08L2gxPlxuICA8aW5wdXQgdi1tb2RlbD1cImVkaXRcIj5cbjwvdGVtcGxhdGU+IiwiaW1wb3J0LW1hcC5qc29uIjoie1xuICBcImltcG9ydHNcIjoge1xuICAgIFwidnVlXCI6IFwiaHR0cHM6Ly9zZmMudnVlanMub3JnL3Z1ZS5ydW50aW1lLmVzbS1icm93c2VyLmpzXCJcbiAgfVxufSJ9

@hugoattal
Copy link
Collaborator Author

hugoattal commented Feb 18, 2022 •
edited
Loading

Don't know why it didn't work earlier, but yeah, perfectly working, sorry 😅

f6267f4

@Akryum Akryum merged commit 09727f4 into main Feb 22, 2022
@Akryum Akryum deleted the folder-auto-expand branch February 22, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akryum Akryum Awaiting requested review from Akryum

Assignees

@hugoattal hugoattal

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto expand parent folders of selected story
2 participants
@hugoattal @Akryum