Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nuxt): add stubs for useNuxtApp and NuxtLink #307

Merged
merged 6 commits into from
Oct 3, 2022
Merged

Conversation

danielroe
Copy link
Collaborator

Description

#286 (comment)

This adds stubs for NuxtLink and useNuxtApp (and hopefully an easy template for how to add other stubbed nuxt components/composables).

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • If it's a new feature, provide a convincing reason to add it. Ideally, you should open a suggestion issue first and have it approved before working on it.
  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@danielroe danielroe added the enhancement New feature or request label Oct 2, 2022
@danielroe danielroe requested a review from Akryum October 2, 2022 22:23
@danielroe danielroe self-assigned this Oct 2, 2022
@netlify
Copy link

netlify bot commented Oct 2, 2022

Deploy Preview for histoire-controls failed.

Name Link
🔨 Latest commit fb99e81
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/633a409293a5bf00086d1959

@netlify
Copy link

netlify bot commented Oct 2, 2022

Deploy Preview for histoire-examples-svelte3 failed.

Name Link
🔨 Latest commit fb99e81
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-svelte3/deploys/633a4092fc14540008d5af03

@netlify
Copy link

netlify bot commented Oct 2, 2022

Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit fb99e81
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/633a40927a65a500082aabc5
😎 Deploy Preview https://deploy-preview-307--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 2, 2022

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit fb99e81
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/633a40925d2977000aeb94ce
😎 Deploy Preview https://deploy-preview-307--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Akryum Akryum merged commit 8aca3c2 into main Oct 3, 2022
@Akryum Akryum deleted the feat/nuxt-stubs branch October 3, 2022 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants