You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When running Histoire in a containerised environment (Docker etc) which has been configured with an odd number of cpus e.g 3, 5, 7, 9 Histoire calculates the number of threads to use as a double e.g 1.5, 2.5, 3.5, 4.5.
I will submit a PR which changes the way that Histoire calculates the number of threads using Math.floor to ensure the final result is an integer.
Reproduction
I'm unable to provide a reproduction as I'm not able to configure the number of vCPUs on StackBlitz, however, I believe my description is sufficient to understand the issue.
Describe the bug
When running Histoire in a containerised environment (Docker etc) which has been configured with an odd number of cpus e.g 3, 5, 7, 9 Histoire calculates the number of threads to use as a double e.g 1.5, 2.5, 3.5, 4.5.
This double is then passed to Tinypool which attempts to initialise an array using the double e.g.
new Array(1.5)
which causes an error.I will submit a PR which changes the way that Histoire calculates the number of threads using Math.floor to ensure the final result is an integer.
Reproduction
I'm unable to provide a reproduction as I'm not able to configure the number of vCPUs on StackBlitz, however, I believe my description is sufficient to understand the issue.
System Info
Used Package Manager
npm
Validations
The text was updated successfully, but these errors were encountered: