vite 4 support with new sveltekit versions

[hexagon6]

Clear and concise description of the problem

When trying to install newer versions of @sveltejs/kit I receive the following errors:

Conflicting peer dependency: [email protected]

$ npm i @sveltejs/kit@next
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/vite
npm ERR!   dev vite@"^4.0.1" from the root project
npm ERR!   peer vite@"^4.0.0" from @sveltejs/[email protected]
npm ERR!   node_modules/@sveltejs/kit
npm ERR!     dev @sveltejs/kit@"1.0.0-next.584" from the root project
npm ERR!   2 more (@sveltejs/vite-plugin-svelte, vitefu)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer vite@"^2.9.0 || ^3.0.0" from [email protected]
npm ERR! node_modules/histoire
npm ERR!   peer histoire@"^0.11.9" from @histoire/[email protected]
npm ERR!   node_modules/@histoire/plugin-svelte
npm ERR!     dev @histoire/plugin-svelte@"^0.11.9" from the root project
npm ERR!   dev histoire@"^0.11.9" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/vite
npm ERR!   peer vite@"^2.9.0 || ^3.0.0" from [email protected]
npm ERR!   node_modules/histoire
npm ERR!     peer histoire@"^0.11.9" from @histoire/[email protected]
npm ERR!     node_modules/@histoire/plugin-svelte
npm ERR!       dev @histoire/plugin-svelte@"^0.11.9" from the root project
npm ERR!     dev histoire@"^0.11.9" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /home/user/.npm/_logs/2022-12-13T10_41_25_581Z-eresolve-report.txt

Suggested solution

This looks like a limitation on peerDependencies of vite versions to 2 and 3, but not 4.

Assuming this is the only part missing updating the peerDependencies to include "vite": "^4".

Changing package.json of [email protected]:

Change from

  "peerDependencies": {
    "vite": "^2.9.0 || ^3.0.0"
  },

Change to

  "peerDependencies": {
    "vite": "^2.9.0 || ^3.0.0 || ^4.0.0"
  },

Or similar might resolve the npm install issue.

I have tested my stories with vite 4 and it seems to work with this version.

Alternative

Staying on @sveltejs/[email protected] and vite 3 works.

Additional context

Using @sveltejs/[email protected] and trying to upgrading to more recent versions fail due to histoire dependency not allowing it.

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that requests the same feature to avoid creating a duplicate.

[hexagon6]

Thanks very much @Akryum ! I enjoy working with histoire! <3