Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aggregate metrics #13

Merged
merged 7 commits into from
Nov 25, 2024
Merged

fix: aggregate metrics #13

merged 7 commits into from
Nov 25, 2024

Conversation

hirokisan
Copy link
Owner

@hirokisan hirokisan commented Nov 25, 2024

  • fix aggregate metrics for individual
    • prs_count: it was only 1 smaller
    • comments_count.average
    • commits_count.average
    • changed_files_count.average
  • test overall
  • refactor modules

@hirokisan hirokisan changed the title test: overall fix: aggregate metrics Nov 25, 2024
Comment on lines -456 to -462
summaries
.entry(individual.clone())
.and_modify(|summary| {
if *individual == author {
summary.prs_count += 1
}
})
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prs_count: it was only 1 smaller

@hirokisan hirokisan marked this pull request as ready for review November 25, 2024 09:30
@hirokisan hirokisan merged commit ccd6bf4 into main Nov 25, 2024
3 checks passed
@hirokisan hirokisan deleted the test-overall branch November 25, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant