feat: support custom websocket dialer #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hirokisan
reviewed
Nov 27, 2024
Comment on lines
-41
to
+53
| c, _, err := websocket.DefaultDialer.Dial(url, nil) | ||
| var c *websocket.Conn | ||
| var err error | ||
| if s.client.dialer != nil { | ||
| c, _, err = s.client.dialer.Dial(url, nil) | ||
| } else { | ||
| c, _, err = websocket.DefaultDialer.Dial(url, nil) | ||
| } |
There was a problem hiding this comment.
It looks good functionally 👍
As an implementation, there may be room for refactoring.
Because the same writing style is used in multiple places
hirokisan
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
WebSocketClientto useWithDialerfor passing a custom dialer config, such as handshake timeout and proxy settings. This would be similar to how the HTTP REST API client supportsWithHTTPClientfor using a custom HTTP client.