Update v5_asset_service.go #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bybit-exchange.github.io/docs/v5/asset/unitransfer It should be fromMemberId, not fromMemberID (and toMemberId, not toMemberID) Also, fromAccountType can be equal to toAccountType e.g you can transfer from one spot subaccount to another spot subaccount
hirokisan
reviewed
Jun 28, 2024
Comment on lines
-171
to
-173
| if p.FromAccountType == p.ToAccountType { | ||
| return fmt.Errorf("toAccountType and fromAccountType must differ") | ||
| } |
There was a problem hiding this comment.
hirokisan
reviewed
Jun 28, 2024
Comment on lines
-153
to
+154
| FromMemberID int `json:"fromMemberID"` | ||
| ToMemberID int `json:"toMemberID"` | ||
| FromMemberID int `json:"fromMemberId"` | ||
| ToMemberID int `json:"toMemberId"` |
hirokisan
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bybit-exchange.github.io/docs/v5/asset/unitransfer
It should be fromMemberId, not fromMemberID (and toMemberId, not toMemberID)
Also, fromAccountType can be equal to toAccountType
e.g you can transfer from one spot subaccount to another spot subaccount