Fix detection of Rails::Engine for Rails 4 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was code saying if defined?(Rails::Engine), but that didn't work on our Rails 4 project. It seems to work better as defined(::Rails::Engine).
hiravgandhi
added a commit
that referenced
this pull request
Feb 12, 2014
Fix detection of Rails::Engine for Rails 4
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We tried to upgrade to angularjs-rails 1.2.12, but now get this error:
when trying to load the application.
Assumedly the culprit is this commit: 137f7cf
We see that locally we get into the
elsif defined? Sprocketscondition, which is probably not what was intended for a Rails 4 project.It works for us now if we use
defined? ::Rails::Engine, but I'm not smart enough with engines to know exactly why or whether it will still work for Rails 3.