feat: Add ability to toggle multiple light/dark classes #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-dura
force-pushed
the
feature/multiple-classes
branch
from
79ccbd8 to
5c04891
Compare
BREAKING CHANGE: `lightClass` and `darkClass` have changed from `string` to `string[]`. Before: `darkClass: 'my-dark-class'`, after: `darkClass: ['my-dark-class']`
chris-dura
force-pushed
the
feature/multiple-classes
branch
from
5c04891 to
c5d1b17
Compare
|
Could you arrayify the class instead? |
yep, I'm just not a fan of union types, so wanted to get your opinion :) |
chris-dura
changed the title
|
This should be a backwards compatible way to support both a single 'myClass' string, a |
hipstersmoothie
approved these changes
Feb 19, 2023
|
@chris-dura Thanks for the contribution! |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:lightClassanddarkClasshave changed fromstringtostring[]. Before:darkClass: 'my-dark-class', after:darkClass: ['my-dark-class']