Subscribed to another event in order to trigger theme change on story change #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hipstersmoothie
requested changes
Jul 13, 2019
There was a problem hiding this comment.
@carlesnunez Thanks for the contribution! Just one small change
src/Tool.tsx
Outdated
| }); | ||
| React.useEffect(() => { | ||
| const channel = props.api.getChannel(); | ||
| channel.on('storyChanged', () => renderTheme()); |
There was a problem hiding this comment.
Could this just be the following?
Suggested change
| channel.on('storyChanged', () => renderTheme()); | |
| channel.on('storyChanged', renderTheme); |
There was a problem hiding this comment.
I think that there not be any problem! I'll commit the change
There was a problem hiding this comment.
Changes made @hipstersmoothie !
|
What's the status of this one? |
|
Good and fast job done @hipstersmoothie !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a bug related to the moment in which we navigate through stories with a theme different to the base configured theme.
In order to fix it we will subscribe to another event that will trigger the same exact logic that the one triggered on stories configured.
It fixes issue: #9