Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bold to the focused word in context for readability #47

Merged
merged 15 commits into from
Apr 6, 2018

Conversation

PonteIneptique
Copy link
Member

Changed required by @ArianePinche in #44

This pull requests breaks the former data model, you'll need to export / import your old corpora.

@coveralls
Copy link

coveralls commented Mar 27, 2018

Coverage Status

Coverage increased (+1.8%) to 93.06% when pulling 7ebfb34 on issue-44 into 566771d on master.

@PonteIneptique
Copy link
Member Author

@Jean-Baptiste-Camps I'd be happy to get your review on this one :)

@PonteIneptique
Copy link
Member Author

I also rewrote the CLI :

  • python manage.py db-create
  • python manage.py db-recreate
  • python manage.py db-fixtures
  • python manage.py run

@PonteIneptique
Copy link
Member Author

Bon, ce qui est bien avec les longs voyages, c'est qu'on a du temps.

@Jean-Baptiste-Camps : quelques gros changements d'interface entre autres, de CLI et un de modèle qui induit d'exporter / réimporter.

L'aide du client se trouve en faisant python manage.py --help

@Jean-Baptiste-Camps
Copy link
Collaborator

Petite remarque, mais je pense que c'est intentionnel: le 'last edit tokens' me renvoie, non pas au dernier token modifié, mais à la dernière page vue de l'écran 'edit tokens', ce qui est un peu différent.

@PonteIneptique
Copy link
Member Author

Yup. Comme je t'ai dit au tel, on s'est limité à la last page pour le moment ;)

Copy link
Collaborator

@Jean-Baptiste-Camps Jean-Baptiste-Camps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parfait, je merge !

@Jean-Baptiste-Camps Jean-Baptiste-Camps merged commit 238564b into master Apr 6, 2018
@Jean-Baptiste-Camps Jean-Baptiste-Camps deleted the issue-44 branch April 6, 2018 10:17
@PonteIneptique
Copy link
Member Author

Merde, il fallait squasher pour faire propre :(

@PonteIneptique
Copy link
Member Author

C'est ce que t'as fait. PARFAIT !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants