WIP: Upgrade Circle to XCode 9.3.1

[aksonov]

In order to make sure that our app works under xcode 9.3 we must use xcode 9.3 for our tests

@southerneer any ideas how to fix mocks?

[southerneer]

Why does the bump to XCode 9.3.1 affect our jest tests? That doesn't make any sense. Does the CircleCI image use a different version of node maybe? I think we should figure out how the change affected the environment before we start fixing things.

[aksonov]

As you can see jest is newer that is why we see errors

…

29 мая 2018 г., в 19:17, Eric Kirkham ***@***.***> написал(а): Why does the bump to XCode 9.3.1 affect our jest tests? That doesn't make any sense. Does the CircleCI image use a different version of node maybe? I think we should figure out how the change affected the environment before we start fixing things. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[southerneer]

Jest is newer? None of your commits update jest.

[southerneer]

I bet the CircleCI image uses Node 10 and causes this: jestjs/jest#2567 (comment)

Testing that theory now

[southerneer]

Yep, that's gotta be it. Here are the specs for the CircleCI XCode 9.3.1 image: https://circle-macos-docs.s3.amazonaws.com/image-manifest/build-419/index.html

[southerneer]

OK, I was able to repro the errors locally by installing Node 10.1.0 (to match CircleCI) and running yarn jest --no-cache.

The fix is to pull in the latest betas of jest: jestjs/jest#6075 (comment)

[southerneer]

Now seeing socket-related errors...probably also related to the node version upgrade. Since we're evaluating appcenter builds as CI this point may be moot.

Uncaught RangeError [ERR_OUT_OF_RANGE]: The value of "value" is out of range. It must be >= 0 and <= 4294967295. Received -301418281
      at checkInt (internal/buffer.js:35:11)
      at writeU_Int32BE (internal/buffer.js:625:3)
      at Buffer.writeUInt32BE (internal/buffer.js:638:10)
      at WebSocketFrame.toBuffer (node_modules/websocket/lib/WebSocketFrame.js:257:24)
      at WebSocketConnection.sendFrame (node_modules/websocket/lib/WebSocketConnection.js:852:43)
      at WebSocketConnection.fragmentAndSend (node_modules/websocket/lib/WebSocketConnection.js:788:14)
      at WebSocketConnection.sendUTF (node_modules/websocket/lib/WebSocketConnection.js:728:10)
      at W3CWebSocket.send (node_modules/websocket/lib/W3CWebSocket.js:116:26)
      at Strophe.Websocket._onOpen (node_modules/strophejs/strophe.js:5587:21)
      at W3CWebSocket._dispatchEvent [as dispatchEvent] (node_modules/yaeti/lib/EventTarget.js:107:17)
      at W3CWebSocket.onConnect (node_modules/websocket/lib/W3CWebSocket.js:208:10)
      at WebSocketClient.<anonymous> (node_modules/websocket/lib/W3CWebSocket.js:55:19)
      at WebSocketClient.succeedHandshake (node_modules/websocket/lib/WebSocketClient.js:335:10)
      at WebSocketClient.validateHandshake (node_modules/websocket/lib/WebSocketClient.js:319:10)
      at ClientRequest.handleRequestUpgrade (node_modules/websocket/lib/WebSocketClient.js:248:14)
      at Socket.socketOnData (_http_client.js:457:11)
      at addChunk (_stream_readable.js:277:12)
      at readableAddChunk (_stream_readable.js:262:11)
      at Socket.Readable.push (_stream_readable.js:217:10)
      at TCP.onread (net.js:638:20)

[southerneer]

Since we're using AppCenter for macOS-based tests this PR no longer applies. Please don't delete the branch, though, until we've finished evaluating AppCenter builds.