Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Convert UIWebView -> WKWebView #4074

Closed
southerneer opened this issue Aug 29, 2019 · 8 comments
Closed

[iOS] Convert UIWebView -> WKWebView #4074

southerneer opened this issue Aug 29, 2019 · 8 comments
Assignees

Comments

@southerneer
Copy link
Contributor

From Apple automated email:

We identified one or more issues with a recent delivery for your app, "tinyrobotStaging" 4.22.0 (2772). Your delivery was successful, but you may wish to correct the following issues in your next delivery:

ITMS-90809: Deprecated API Usage - Apple will stop accepting submissions of apps that use UIWebView APIs . See https://developer.apple.com/documentation/uikit/uiwebview for more information.

I don't think we use WebView directly in our code, but it's probably buried in a dependency.

@aksonov aksonov self-assigned this Aug 30, 2019
@aksonov
Copy link
Contributor

aksonov commented Aug 30, 2019

First, it is warning, so we don't have problem now.

I found two modules use UIWebView to solve this problem for our next version:

  1. React - RN0.59 uses UIWebView, so we must upgrade to RN0.60. I checked that RN0.60 doesn't have this dependency
  2. react-native-device-info, even latest version (2.3.2), uses it, but new version (3.0.0) with required fix will come soon:
    [FIXED, RELEASE IN V3.0.0] UIWebView iOS Deprecated API Usage Warning ITMS-90809 react-native-device-info/react-native-device-info#756

@aksonov
Copy link
Contributor

aksonov commented Sep 5, 2019

I've found that this issue is NOT trivial anymore - DeviceInfo from 3.0 uses async API and we need to change many places.. (as I understand it happens because of async nature of WKWebView API)

southerneer added a commit that referenced this issue Sep 10, 2019
Upgrade react-native-device-info (#4074)
@bengtan
Copy link
Contributor

bengtan commented Sep 12, 2019

Not QA-able. bengtan to monitor.

@aksonov
Copy link
Contributor

aksonov commented Sep 13, 2019

Ugh, looks like Firebase still uses UIWebView (FirebaseDynamicLinks?):
invertase/react-native-firebase#2535
firebase/firebase-ios-sdk#3722

@southerneer
Copy link
Contributor Author

southerneer commented Sep 13, 2019

Ah ok, at least if it's on Firebase to update (as opposed to rn-firebase) then we're probably ok. I would imagine they would have to update that within the next couple weeks. invertase/react-native-firebase#2535 (comment).

Also, this is an App Store warning, not a fail. They'll keep accepting these submissions for now

UIWebView is deprecated but not removed on iOS 12 and is (apparently) also not removed on iOS 13 betas that have started trickling out.

@bengtan bengtan added the BLOCKED This issue has been blocked for some reason. label Sep 16, 2019
@bengtan
Copy link
Contributor

bengtan commented Sep 16, 2019

I guess we're gonna have to wait.

@bengtan bengtan removed the BLOCKED This issue has been blocked for some reason. label Oct 2, 2019
@bengtan
Copy link
Contributor

bengtan commented Oct 2, 2019

I was just reading invertase/react-native-firebase#2535

As I interpret it ... I think the fix is to update the some firebase pod to 6.8.1 or newer (the latest is 6.9.0)? We're currently using 6.6.0.

https://firebase.google.com/support/release-notes/ios#version_681_-_september_10_2019

@bengtan
Copy link
Contributor

bengtan commented Oct 4, 2019

I didn't see an email from Apple/TestFlight after the 4.27.0 release so I think this is resolved.

@bengtan bengtan closed this as completed Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants