Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev] Upgrade mobx dependencies #2441

Closed
southerneer opened this issue Jun 5, 2018 · 4 comments
Closed

[dev] Upgrade mobx dependencies #2441

southerneer opened this issue Jun 5, 2018 · 4 comments
Assignees
@aksonov @southerneer

Comments

@southerneer
Copy link
Contributor

Current: [email protected], [email protected], [email protected]
Latest: [email protected], [email protected], [email protected]

We're a major version behind in all 3 of these vital dependencies. Probably the work necessary to perform the upgrade should be split into 3 tickets, but this will get the discussion started.

We would also need to investigate the breaking changes in each upgrade to determine the effort involved.
@southerneer
Copy link
Contributor Author

@aksonov we would need to change RNRF to upgrade mobx and mobx-react. Have you given any more thought to changing those to peer dependencies in rnrf? Probably it's a matter of merging that PR and adding a warning/error message in RNRF if mobx is not installed.

@southerneer southerneer self-assigned this Jun 6, 2018
@aksonov aksonov removed the Epic label Jun 7, 2018
@aksonov aksonov assigned aksonov and unassigned southerneer Jun 7, 2018
@aksonov
Copy link
Contributor

aksonov commented Jun 7, 2018

No need to create several tickets because all they are very coupled and depends each other - it is almost impossible to do one without others.

@aksonov
Copy link
Contributor

aksonov commented Jun 7, 2018

Accepted that PR and published RNRF 4.0.0.beta.32

aksonov pushed a commit that referenced this issue Jun 7, 2018
mobx upgrade #2441
41c209c
@aksonov aksonov mentioned this issue Jun 7, 2018
Merged
southerneer added a commit that referenced this issue Jun 7, 2018
@southerneer
Merge pull request #2460 from hippware/2441
7b80e3e 
mobx upgrade #2441
@southerneer
Copy link
Contributor Author

Not directly QA-able.

aksonov pushed a commit that referenced this issue Jul 10, 2018
mobx upgrade #2441
1fcaf5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aksonov aksonov

@southerneer southerneer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aksonov @southerneer