This repository has been archived by the owner on Mar 7, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, as a follow-up of the conversation in KinoxKlark/pyimgui#2 here is my fixes.
You don't have to copy the
core.pxd
from imgui, my bad. You only need to have theimgui
module installed or accessible. In my quick toy exemple, I had to copy the lib (.pyd
or.so
) since I didn't install the module but when compiling pyimgui it is automatically installed on your environment for convenience. Thus it is not even necessary to copy anything from pyimgui.I had to include
config-cpp/
for compilation.cimport
is onimgui.core
notcore
(this would beimplot.core
)With theses changes I can compile and I get:
Without any errors!