Object writer changes to implement shorthand syntax for ColumnDefinitions and RowDefinitions #4
Conversation
| ArgumentNullException.ThrowIfNull(destinationType); | ||
| if (destinationType == typeof(string) && value is ColumnDefinition columnDefinition) | ||
| { | ||
| return GridLengthConverter.ToString(columnDefinition.Width, cultureInfo); |
There was a problem hiding this comment.
You need to do more checks, you cannot express columns/rows that have min/max/offset set
| { | ||
| if (value is string input) | ||
| { | ||
| RowDefinition rowDefinition = new RowDefinition{ Height = GridLengthConverter.FromString(input, cultureInfo) }; |
There was a problem hiding this comment.
You might be able to use type descriptor to decide whether you should return column or row and have only one converter (possibly even the grid length one), but if this ends up being public, it possibly is a better API separately
| { | ||
| ThrowExceptionWithLine(SR.Format(SR.ParserReadOnlyProp, attribLocalName)); | ||
| } | ||
| } | ||
|
|
||
| if (propInfo != null && !XamlTypeMapper.IsAllowedPropertySet(propInfo)) | ||
| if (propInfo != null && !CanInitializeCollectionFromString(propInfo.PropertyType) && !XamlTypeMapper.IsAllowedPropertySet(propInfo)) |
There was a problem hiding this comment.
I would probably add the new condition at the end for consistency and performance
| @@ -782,6 +782,10 @@ public override void WriteEndMember() | |||
| shouldSetValue = true; | |||
| _context.ParentKeyIsUnconverted = true; | |||
| } | |||
| else if (valueXamlType == XamlLanguage.String && property.Type.IsCollection && property.TypeConverter == null && property.Type.ItemType.TypeConverter != null) | |||
There was a problem hiding this comment.
this would exclude collections of type string/object because they don't need a converter
There was a problem hiding this comment.
(not necessarily bad thing and can be enabled later)
| { | ||
| return IsACollection(type) && XamlTypeMapper.GetTypeConverterType(type) == null | ||
| && XamlTypeMapper.GetTypeConverterType(GetCollectionItemType(type)) != null; | ||
| } |
There was a problem hiding this comment.
What you could test for though is whether the item type converter can convert from string
There was a problem hiding this comment.
But again you need to decide whether it is desirable to throw "no setter" error or converter error. Maybe the latter is better in this case too.
No description provided.