type convertor xaml shortening #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub.com/himgoyalmicro/wpf into user/himgoyal/TypeConvertorXamlShortening
|
Few points before further review :
|
dipeshmsft
reviewed
Sep 5, 2024
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Controls/Grid.cs
Show resolved
Hide resolved
|
Is there a possibility to combine the TypeConverters in one ? |
…initionCollectionConverter
dipeshmsft
reviewed
Sep 6, 2024
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Controls/Grid.cs
Outdated
Show resolved
Hide resolved
| @@ -5537,6 +5541,8 @@ private Type InitializeOneType(KnownElements knownElement) | |||
| case KnownElements.DateTimeConverter: t = typeof(DateTimeConverter); break; | |||
| case KnownElements.DateTimeConverter2: t = typeof(DateTimeConverter2); break; | |||
| case KnownElements.UriTypeConverter: t = typeof(UriTypeConverter); break; | |||
| case KnownElements.RowDefinitionCollectionConverter: t = _asmFramework.GetType("System.Windows.Controls.RowDefinitionCollectionConverter"); break; | |||
There was a problem hiding this comment.
Why have you used this method ? typeof should have worked.
...Wpf/src/PresentationFramework/System/Windows/Controls/ColumnDefinitionCollectionConverter.cs
Show resolved
Hide resolved
...Wpf/src/PresentationFramework/System/Windows/Controls/ColumnDefinitionCollectionConverter.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Controls/Grid.cs
Outdated
Show resolved
Hide resolved
...et.Wpf/src/PresentationFramework/System/Windows/Controls/RowDefinitionCollectionConverter.cs
Show resolved
Hide resolved
| { | ||
| if (value is string input) | ||
| { | ||
| IProvideValueTarget ipvt = context?.GetService(typeof(IProvideValueTarget)) as IProvideValueTarget; |
There was a problem hiding this comment.
what should we do when string is empty or null ?
| } | ||
| } | ||
|
|
||
| return base.ConvertFrom(context, culture, value); |
There was a problem hiding this comment.
Do we need to call this base.ConvertFrom method ? We know that base cannot handle the conversion anyway
....Wpf/src/PresentationFramework/System/Windows/Markup/Baml2006/WpfGeneratedKnownProperties.cs
Outdated
Show resolved
Hide resolved
....Wpf/src/PresentationFramework/System/Windows/Markup/Baml2006/WpfGeneratedKnownProperties.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.