Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enabling and redirecting twibbon button to the target link #10

Merged
merged 12 commits into from
Oct 17, 2024
Merged

feat: enabling and redirecting twibbon button to the target link #10

merged 12 commits into from
Oct 17, 2024

Conversation

Zreaei
Copy link
Collaborator

@Zreaei Zreaei commented Oct 17, 2024

Jenis PR (centang semua yang berlaku)

  • Fitur Baru
  • Refaktor
  • Perbaikan Bug
  • Optimasi
  • Pembaruan Dokumentasi

Deskripsi

  • Saya menambahkan fitur baru
  • Saya memperbaiki fitur yang sudah ada
  • Saya memperbaiki bug
  • Saya melakukan optimasi
  • Saya menambah dokumentasi
  • Saya memperbaiki dokumentasi

Terkait Tiket & Dokumen

  • Terkait Isu #
  • Menutup #

Pengujian

Beberapa pengujian akan dilakukan otomatis dengan GitHub Actions saat pull request dibuat

  • Tes linting eslint npm run lint || bun run lint
  • Pesan commit sesuai Conventional Commits npm run commitlint || bun run commitlint
  • Build lokal npm run build || bun run build

Checklist Aksesibilitas UI

Jika PR Anda menyertakan perubahan UI, silakan ceklis daftar berikut ini:

  • HTML Semantik diterapkan?
  • Kontras warna diuji?

Untuk informasi lebih lanjut, cek tautan berikut: Forem Accessibility Docs.

Lingkungan Pengembangan

Saya menggunakan:

Misal: tuliskan hanya "Windows" jika Anda menggunakan Windows

  • os = windows

@DikDns
Copy link
Member

DikDns commented Oct 17, 2024

LGTM, Thanks for your contributions!

@DikDns DikDns closed this Oct 17, 2024
@DikDns DikDns reopened this Oct 17, 2024
@DikDns DikDns merged commit cd8cc62 into main Oct 17, 2024
3 checks passed
@DikDns DikDns deleted the zamzami branch October 17, 2024 14:39
DikDns pushed a commit that referenced this pull request Oct 18, 2024
@interstellardeer
feat: enabling and redirecting booklet button to the target link (#10) (
c407547 
#11)

* add sponsors

* chore: add Allo Bank and Kahf logo

* fix: adjust sponsor logo sizes and add new logos

* fix: add new logos

* fix: fix group-mabim.ts name that containing whitespace

* feat: enabling and redirecting booklet button to the target link (#11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zreaei @DikDns